code cleanup: remove ssml_ignore_l_angle.#886
Merged
Conversation
It is supposed to be used with SSML for reading < (<) and & (&) when invoking espeak-ng --punct -m. However, it looks like the code is dead since removing it doesn't fail the ssml reference test.
Member
|
@michaelDCurran, @feerrenrut, probably NVDA community is the most active users of SSML features of the eSpeak NG. Can you comment on this? |
Member
|
I think, we can throw that part out. |
Contributor
|
We can update the version of espeak used by NVDA. Then this will get some testing with our alpha users. See also: #857 |
Collaborator
Author
|
That wold be good. The SSML implementation has bugs related to voice changes and sentence endings. Finding and fixing them is easier if we're able to refactor and remove dead code.
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like ssml_ignore_l_angle is just dead code. Can you find any use for it?
It is only set in AnnouncePunctuation if
end_clause != 0. Even when manually setting ssml_ignore_l_angle there seems to be no effect on anything.For example, this doesn't change after the commit:
src/espeak-ng -m --punct "<speak>Here's a < and a &, and < and &. This is still <(<)(<)</speak>"If a use case for this is found it should be better documented.
looks like commit 1a2f454 from 2008 was first to have ssml_ignore_l_angle in AnnouncePunctuation.