-
-
Notifications
You must be signed in to change notification settings - Fork 83
feat: Consider bulk suppressions via the Node.js API #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @adf0nt3s!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
| - `suppressionsLocation: string | undefined`: Specifies the path to the suppressions file (`eslint-suppressions.json`). This path can be absolute or relative to the `cwd`. | ||
| - If `suppressionsLocation` is provided, ESLint will attempt to load suppressions from that specific file path. | ||
| - If `suppressionsLocation` is not provided (or is `undefined`), ESLint will default to looking for `eslint-suppressions.json` in the `cwd`. | ||
| - `applySuppressions` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nzakas per your suggestion on the previous version of this RFC, i've introduced a new constructor option
Summary
This RFC continues work on the proposal for integrating bulk suppressions support into the Node.js API via the ESLint and LegacyESLint classes. It specifically focusing on considering existing bulk suppressions when linting files or text through the API, ensuring that suppression files (eslint-suppressions.json) created via CLI commands are automatically respected when using the programmatic API.
The scope is limited to applying existing suppressions during linting and does not include suppression file manipulation features (such as --suppress-all, --suppress-rule, or --prune-suppressions), which remain CLI-exclusive functionalities.
Related Issues
eslint/eslint#19603
#133