chore: update eslint and eslint-config-eslint#737
Merged
Conversation
1 task
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s linting toolchain to ESLint v10 and the corresponding eslint-config-eslint v14, and adjusts a couple of repository files to keep CI/lint/type generation working with the new versions (notably removing now-unnecessary jsdoc/valid-types disables and aligning Espree’s declaration-build TS target).
Changes:
- Bump devDependencies:
eslintto^10.0.3,eslint-config-eslintto^14.0.0, and@typescript-eslint/parserto^8.56.1. - Update Espree’s type-generation
tsconfigtargets fromes5toes6to avoid type issues caused by downstream.d.tsgeneration. - Remove
eslint-disable/enable jsdoc/valid-typesblocks that were previously workarounds for older JSDoc/type parsing behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/espree/tsconfig.json | Bumps TS target to es6 for declaration generation to avoid type errors triggered by newer dependencies. |
| packages/espree/tsconfig-cjs.json | Same target bump for the CJS declaration build. |
| packages/espree/lib/types.js | Removes jsdoc/valid-types disable/enable comments that should no longer be needed with the updated lint stack. |
| packages/eslint-visitor-keys/lib/visitor-keys.js | Removes the jsdoc/valid-types disable/enable wrapper around the readonly JSDoc type. |
| packages/eslint-visitor-keys/lib/index.js | Removes the jsdoc/valid-types disable/enable wrapper around JSDoc types. |
| package.json | Updates ESLint-related devDependencies to the requested versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR replaces #736.
In #736, two issues caused the CI to fail.
First, an ESLint comment related to
jsdoccontained a TODO to remove it once a newjsdocplugin version is released.Second, the ES target in
tsconfigcaused a problem. The#privatemember in@eslint/plugin-kittriggered a type error. I'm not entirely sure why this unrelated dependency caused the error, but I resolved it by changing the target fromes5toes6. I verified that the generated.d.tsand.d.ctsfiles are unchanged, so updating the target appears safe. (I also checked the#privatekeyword in@eslint/plugin-kit; it has existed since the initial version and wasn't introduced in the new release.)What changes did you make? (Give an overview)
This PR updates
eslintandeslint-config-eslintto the latest.Related Issues
Ref: #736
Is there anything you'd like reviewers to focus on?
N/A