Skip to content

ci: pin Node.js 25.6.1#733

Merged
mdjermanovic merged 1 commit intomainfrom
ci/pin-nodejs
Feb 26, 2026
Merged

ci: pin Node.js 25.6.1#733
mdjermanovic merged 1 commit intomainfrom
ci/pin-nodejs

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Feb 26, 2026

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR follows up on eslint/eslint#20559.

It pins Node.js to v25.6.1.

The recently released Node.js 25.7.0 contains a bug that causes our CI to fail: nodejs/node#61971

Related: #732

What changes did you make? (Give an overview)

It pins Node.js to v25.6.1.

Related Issues

Related: #732, nodejs/node#61971, eslint/eslint#20559

Is there anything you'd like reviewers to focus on?

N/A

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Feb 26, 2026
@lumirlumir lumirlumir marked this pull request as ready for review February 26, 2026 10:46
Copilot AI review requested due to automatic review settings February 26, 2026 10:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the CI Node.js 25 runtime to a specific patch version to avoid an upstream Node.js regression that is currently breaking ESLint’s CI (per linked Node issue / prior ESLint PR context).

Changes:

  • Update the CI test matrix to use Node.js 25.6.1 instead of 25.x.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit a8aafe4 into main Feb 26, 2026
23 checks passed
@mdjermanovic mdjermanovic deleted the ci/pin-nodejs branch February 26, 2026 12:01
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants