fix: Derive espree.Syntax from espree.VisitorKeys#532
fix: Derive espree.Syntax from espree.VisitorKeys#532mdjermanovic merged 2 commits intoeslint:mainfrom
Conversation
|
Hi @codeworrior!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
|
Sorry for not immediately signing the CLA. I have to clarify with my employer first. |
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Just want another set of eyes before merging.
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Waiting for CLA before merging.
|
Sorry for the delay. After my employer decided to sign the corporate CLA, we struggled a bit with the process and tooling, but now we're done. |
|
Thanks for contributing! |
Fixes #531.
If removing the
lib/ast-node-types.jsis regarded as an incompatible change, I can restore it and leave the cleanup up to you in one of the upcoming major releases. My assumption was that the module is rather an internal thing and not part of your APIs.