Merged
Conversation
|
Hi @fisker!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
Contributor
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
DMartens
reviewed
Feb 11, 2026
DMartens
reviewed
Feb 11, 2026
DMartens
reviewed
Feb 11, 2026
|
Apologies for taking a while to get back to you. |
DMartens
approved these changes
Feb 17, 2026
DMartens
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks for working on this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Currently, Prettier bundles
espree, only the parser parts needed, but esbuild can't tree-shake the unusedeslint-visitor-keys, we use a script to replace unwanted code https://github.com/prettier/prettier/blob/5017d66ea76a7c513d7499b178794dcb6084b6ee/scripts/build/packages/prettier.js#L510This PR makes espree tree-shakable.
What changes did you make? (Give an overview)
sideEffects: falseto package.jsonReduce
from 474KB to 469KB
Manually mark
acornandacorn-jsxside effects free, and runRelated Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A