Skip to content

fix: restore comments property on tokenize() return value#721

Merged
fasttime merged 1 commit intomainfrom
tokenize-tokens-comments
Jan 18, 2026
Merged

fix: restore comments property on tokenize() return value#721
fasttime merged 1 commit intomainfrom
tokenize-tokens-comments

Conversation

@mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Restores comments property on tokenize() return value. Also adds a test to confirm that tokenize() returns array of tokens with this property on the array.

The current head version of espree breaks ESLint because ESLint uses this property in astUtils.canTokensBeAdjacent().

What changes did you make? (Give an overview)

Restored comments property on tokenize() return value.

Related Issues

This property has been removed in #705.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 18, 2026
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Jan 18, 2026
@fasttime fasttime moved this from Triaging to Implementing in Triage Jan 18, 2026
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 5603ea9 into main Jan 18, 2026
17 checks passed
@fasttime fasttime deleted the tokenize-tokens-comments branch January 18, 2026 13:41
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jan 18, 2026
@eslintbot eslintbot mentioned this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants