Upgrade: acorn to ^4.0.11 #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I guess acornjs/acorn#507 is the last issue to upgrade acorn. |
11 tasks
Member
Author
|
Memo: this should fix eslint/eslint#6542. |
Member
Author
|
I'm sure this is ready to merge. |
not-an-aardvark
approved these changes
Feb 8, 2017
Member
not-an-aardvark
left a comment
There was a problem hiding this comment.
LGTM
eslint-canary also runs successfully with this change.
gyandeeps
approved these changes
Feb 9, 2017
Member
|
Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Acorn to latest.
It needs to fix some tests.
6/destructuring/named-param.It gets correct AST nodes about ExportDeclarations with expressions. (it gets to not make wrong EmptyStatement node.)EDIT: this is a bug.4 errors about below remain: