fix: include variable name in no-useless-assignment message#20581
Merged
lumirlumir merged 1 commit intoeslint:mainfrom Mar 3, 2026
Merged
fix: include variable name in no-useless-assignment message#20581lumirlumir merged 1 commit intoeslint:mainfrom
no-useless-assignment message#20581lumirlumir merged 1 commit intoeslint:mainfrom
Conversation
3 tasks
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
approved these changes
Mar 2, 2026
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for couple days if anyone else would like to take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR improves
no-useless-assignmentreports by including the assigned identifier name in the message (e.g.The value assigned to 'v' is not used in subsequent statements.), which makes it easier to triage multiple occurrences in a file.Fixes #20572
Is there anything you'd like reviewers to focus on?