chore: disable eslint-comments/no-unused-disable rule#20578
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
|
@mdjermanovic Maybe ESLint should validate the |
Member
|
Just for reference, the PR with the fix was merged at eslint-community/eslint-plugin-eslint-comments#310 and released in v4.7.1. @SukkaW I've briefly written my thoughts in the comment (eslint-community/eslint-plugin-eslint-comments#310 (comment)), but it might be worth discussing this further. |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Disables
@eslint-community/eslint-comments/no-unused-disablerule.This rule is deprecated in favor of the built-in
linterOptions.reportUnusedDisabledDirectivesoption which we already have enabled so there's no need to use this rule in our config anymore.Also, this rule's deprecation meta is invalid which currently causes our CI to fail.
What changes did you make? (Give an overview)
Removed this rule from eslint-config-eslint.
Is there anything you'd like reviewers to focus on?