Skip to content

chore: update tsconfig.json in eslint-config-eslint#20551

Merged
lumirlumir merged 1 commit intomainfrom
update-eslint-config-eslint-tsconfig
Feb 24, 2026
Merged

chore: update tsconfig.json in eslint-config-eslint#20551
lumirlumir merged 1 commit intomainfrom
update-eslint-config-eslint-tsconfig

Conversation

@fasttime
Copy link
Member

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Update build, revert temporary change

What changes did you make? (Give an overview)

This PR adds "types": [] to the TypeScript compiler options of eslint-config-eslint. In TypeScript 6 it's recommended to set this option explicitly (https://devblogs.microsoft.com/typescript/announcing-typescript-6-0-beta/#up-front-adjustments).

The above change makes "skipLibCheck": true unnecessary, since there are no more external types to check. By removing skipLibCheck, this PR also reverts #20323, which was merged in preparation for the v10 release.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Feb 23, 2026
@netlify
Copy link

netlify bot commented Feb 23, 2026

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 197c849
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/699c78fb811868000833be23

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Feb 23, 2026
@fasttime fasttime marked this pull request as ready for review February 23, 2026 16:14
@fasttime fasttime requested a review from a team as a code owner February 23, 2026 16:14
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Feb 24, 2026
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir lumirlumir merged commit efc5aef into main Feb 24, 2026
37 of 38 checks passed
@lumirlumir lumirlumir deleted the update-eslint-config-eslint-tsconfig branch February 24, 2026 09:36
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This change is not user-facing

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants