Skip to content

[Reference] feat!: factor in schema defaults for rule options#17580

Closed
JoshuaKGoldberg wants to merge 2 commits into
eslint:mainfrom
JoshuaKGoldberg:rule-options-defaults
Closed

[Reference] feat!: factor in schema defaults for rule options#17580
JoshuaKGoldberg wants to merge 2 commits into
eslint:mainfrom
JoshuaKGoldberg:rule-options-defaults

Conversation

@JoshuaKGoldberg

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Augments getRuleOptions to factor in the rule's schema. Specifically, it:

  • Defaults undefined options to the schema's .default value
  • Recursively creates {} objects

Is there anything you'd like reviewers to focus on?

Sending an RFC momentarily. ✅

@eslint-github-bot

eslint-github-bot Bot commented Sep 18, 2023

Copy link
Copy Markdown

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@netlify

netlify Bot commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 4781b9e
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/650a9aa5bb2c9a0008218418

@eslint-github-bot

eslint-github-bot Bot commented Sep 18, 2023

Copy link
Copy Markdown

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot

eslint-github-bot Bot commented Sep 18, 2023

Copy link
Copy Markdown

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

This was referenced Sep 18, 2023
Merged
Closed
@eslint-github-bot

eslint-github-bot Bot commented Sep 20, 2023

Copy link
Copy Markdown

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@github-actions

github-actions Bot commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added the Stale label Sep 30, 2023
@Rec0iL99 Rec0iL99 removed the Stale label Oct 1, 2023
@github-actions

github-actions Bot commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added the Stale label Oct 11, 2023
@Rec0iL99 Rec0iL99 removed the Stale label Oct 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the rule-options-defaults branch October 14, 2023 17:04
@JoshuaKGoldberg JoshuaKGoldberg restored the rule-options-defaults branch October 14, 2023 17:04
@eslint-github-bot

eslint-github-bot Bot commented Oct 16, 2023

Copy link
Copy Markdown

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Apr 12, 2024
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

archived due to age This issue has been archived; please open a new issue for any further discussion

Projects

Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoshuaKGoldberg @Rec0iL99