Breaking: remove TDZ scopes (fixes #10245)#10270
Merged
platinumazure merged 2 commits intomasterfrom Apr 28, 2018
Merged
Conversation
This was referenced Apr 26, 2018
Closed
platinumazure
approved these changes
Apr 28, 2018
Member
|
I removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: fixes #10245.
What changes did you make? (Give an overview)
This PR upgrades
eslint-scopepackage to remove TDZ scopes.This depends on
github:eslint/eslint-scope#remove-tdz-scopein order to check no test failing.Is there anything you'd like reviewers to focus on?
Nothing in particular.