fix: FlatESLint#getRulesMetaForResults shouldn't throw on unknown rules (#17393)

mdjermanovic · nzakas · web-flow · commit 9803c7c04078 · 2023-07-21T11:09:22.000-04:00
* fix: FlatESLint#getRulesMetaForResults shouldn't throw on unknown rules Fixes #17343 * refactor test check Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com> --------- Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
diff --git a/lib/eslint/flat-eslint.js b/lib/eslint/flat-eslint.js
@@ -714,12 +714,10 @@ class FlatESLint {
                 }
                 const rule = getRuleFromConfig(ruleId, config);
 
-                // ensure the rule exists
-                if (!rule) {
-                    throw new TypeError(`Could not find the rule "${ruleId}".`);
+                // ignore unknown rules
+                if (rule) {
+                    resultRules.set(ruleId, rule);
                 }
-
-                resultRules.set(ruleId, rule);
             }
         }
 
diff --git a/tests/lib/eslint/flat-eslint.js b/tests/lib/eslint/flat-eslint.js
@@ -4478,6 +4478,42 @@ describe("FlatESLint", () => {
 
             assert.deepStrictEqual(rulesMeta, { "no-var": coreRules.get("no-var").meta });
         });
+
+        it("should return empty object if all messages are related to unknown rules", async () => {
+            const engine = new FlatESLint({
+                overrideConfigFile: true
+            });
+
+            const results = await engine.lintText("// eslint-disable-line foo, bar/baz, bar/baz/qux");
+
+            assert.strictEqual(results[0].messages.length, 3);
+            assert.strictEqual(results[0].messages[0].ruleId, "foo");
+            assert.strictEqual(results[0].messages[1].ruleId, "bar/baz");
+            assert.strictEqual(results[0].messages[2].ruleId, "bar/baz/qux");
+
+            const rulesMeta = engine.getRulesMetaForResults(results);
+
+            assert.strictEqual(Object.keys(rulesMeta).length, 0);
+        });
+
+        it("should return object with meta of known rules if some messages are related to unknown rules", async () => {
+            const engine = new FlatESLint({
+                overrideConfigFile: true,
+                overrideConfig: { rules: { "no-var": "warn" } }
+            });
+
+            const results = await engine.lintText("// eslint-disable-line foo, bar/baz, bar/baz/qux\nvar x;");
+
+            assert.strictEqual(results[0].messages.length, 4);
+            assert.strictEqual(results[0].messages[0].ruleId, "foo");
+            assert.strictEqual(results[0].messages[1].ruleId, "bar/baz");
+            assert.strictEqual(results[0].messages[2].ruleId, "bar/baz/qux");
+            assert.strictEqual(results[0].messages[3].ruleId, "no-var");
+
+            const rulesMeta = engine.getRulesMetaForResults(results);
+
+            assert.deepStrictEqual(rulesMeta, { "no-var": coreRules.get("no-var").meta });
+        });
     });
 
     describe("outputFixes()", () => {

Original file line number	Diff line number	Diff line change
`@@ -714,12 +714,10 @@ class FlatESLint {`
`714`	`714`	`}`
`715`	`715`	`const rule = getRuleFromConfig(ruleId, config);`
`716`	`716`
`717`		`- // ensure the rule exists`
`718`		`- if (!rule) {`
`719`		- throw new TypeError(`Could not find the rule "${ruleId}".`);
	`717`	`+ // ignore unknown rules`
	`718`	`+ if (rule) {`
	`719`	`+ resultRules.set(ruleId, rule);`
`720`	`720`	`}`
`721`		`-`
`722`		`- resultRules.set(ruleId, rule);`
`723`	`721`	`}`
`724`	`722`	`}`
`725`	`723`