Skip to content

ci: use standalone Corepack for Yarn#107

Merged
nzakas merged 1 commit into
eslint:mainfrom
MikeMcC399:ci/corepack-standalone-yarn
Apr 8, 2025
Merged

ci: use standalone Corepack for Yarn#107
nzakas merged 1 commit into
eslint:mainfrom
MikeMcC399:ci/corepack-standalone-yarn

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request?

The yarn-install job in the workflow .github/workflows/ci-build-all-pm.yml relies on a version of Corepack bundled with Node.js. The Node.js website https://nodejs.org/docs/latest/api/corepack.html states "... Corepack itself will no longer be distributed with future versions of Node.js." which would cause the workflow to break.

Yarn > Installation now recommends using

npm install -g corepack

What changes did you make? (Give an overview)

In the workflow .github/workflows/ci-build-all-pm.yml, add npm install -g corepack@latest before using Corepack in the job yarn-install.

Note that although a global install of Corepack currently automatically enables Corepack, the explicit command to enable Corepack is retained in the workflow in case a future release of Corepack changes this undocumented default.

Related Issues

Is there anything you'd like reviewers to focus on?

Check that https://github.com/eslint/css/actions/workflows/ci-build-all-pm.yml completes successfully

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Apr 5, 2025
@MikeMcC399

Copy link
Copy Markdown
Contributor Author

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 5, 2025 08:47

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit f24f4d5 into eslint:main Apr 8, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Complete in Triage Apr 8, 2025
@MikeMcC399 MikeMcC399 deleted the ci/corepack-standalone-yarn branch April 9, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants