Skip to content

ci: disable fail-fast in matrix#106

Merged
nzakas merged 2 commits into
eslint:mainfrom
MikeMcC399:ci/no-fail-fast
Apr 8, 2025
Merged

ci: disable fail-fast in matrix#106
nzakas merged 2 commits into
eslint:mainfrom
MikeMcC399:ci/no-fail-fast

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request?

This change allows all matrix jobs in the workflow .github/workflows/ci.yml to run to completion, giving a better overview in case of failures, so that it is clear whether only certain environments or all environments are affected.

What changes did you make? (Give an overview)

In the workflow .github/workflows/ci.yml add fail-fast: true to the matrix parameters.

Related Issues

Is there anything you'd like reviewers to focus on?

Check that in https://github.com/eslint/css/actions/workflows/ci.yml no jobs are cancelled because other jobs have failed. All jobs should run independently of each other.

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

All jobs are currently passing, so at the moment the effect of fail-fast: false is not tested. I suggest merging in any case though as a precaution for future potential workflow failures.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 5, 2025 06:16

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit e3ef125 into eslint:main Apr 8, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Complete in Triage Apr 8, 2025
@MikeMcC399 MikeMcC399 deleted the ci/no-fail-fast branch April 9, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Change Request: Disable CI fail-fast for matrix

2 participants