Conversation
rviscomi
reviewed
Mar 18, 2025
rviscomi
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me 👍
Another approach could be to target the PseudoClassSelector and PseudoElementSelector types specifically, as more of an allowlist approach. It'd be nice if there was a way to OR them together so you can easily reuse the same function handler, eg:
'PseudoClassSelector,PseudoElementSelector'(node) {}
Member
Author
|
@rviscomi good point, and that actually does work. :) |
rviscomi
approved these changes
Mar 18, 2025
rviscomi
left a comment
Contributor
There was a problem hiding this comment.
Ha! Ok great. I briefly tested it locally and gave up as soon as I saw test failures, but happy to see that it actually works.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fixes incorrect flagging of
highlightclass name inrequire-baslineWhat changes did you make? (Give an overview)
require-baselineto skip class, type, ID, and attribute selectorsRelated Issues
fixes #91
Is there anything you'd like reviewers to focus on?
Ping @rviscomi can you take a look at this to make sure I fixed it correctly?