feat: CSS nesting baseline support#87
Merged
Merged
Conversation
nzakas
approved these changes
Mar 17, 2025
nzakas
left a comment
Member
There was a problem hiding this comment.
LGTM.
Should the
nestingselector ID be saved as a constant somewhere, or is it ok to hard-code it in theNestingSelectorhandler?
I think it's fine to keep it local to where it's being used. 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add support for evaluating baseline support for CSS nesting
What changes did you make? (Give an overview)
NestingSelectorkey that checks fornestingselector availabilityisSupportedso unknown feature statuses are supported by default (if thenestingID happens to change, the test will fail and there won't be a runtime error)Related Issues
fixes #85
Is there anything you'd like reviewers to focus on?
Should the
nestingselector ID be saved as a constant somewhere, or is it ok to hard-code it in theNestingSelectorhandler?