refactor(dashboard): migrate small panels — overview / tools / permissions / plans / hooks#34
Merged
Merged
Conversation
…sions / plans / hooks Stage 4 PR 4.1 from #28. Five panels move out of dashboard/app.js: - panels/overview.ts (53 LoC) — Live Cockpit metric grid - panels/tools.ts (71 LoC) — registered-tools table - panels/permissions.ts (169 LoC) — allowlist CRUD + builtin groupings; private groupByVerb helper folded in - panels/plans.ts (104 LoC) — archived-plan browser + step view - panels/hooks.ts (105 LoC) — JSON editor for project + global hooks Plus shared pieces these panels need: - components/metric-card.ts (23 LoC) — used by overview now and by system in a later PR - lib/html.ts (4 LoC) — single htm.bind(h) export so panels don't each rebind dashboard/app.js loses 419 LoC. Bundle holds at ~122 KB; CDN imports stay external. Typecheck + lint + 1682 tests still pass. No behavior change.
12 tasks
esengine
added a commit
that referenced
this pull request
May 11, 2026
) The reporter showed a JSON snippet rendered as `{ "apiKey": "..." }` inside a code fence — the model emitted literal HTML entities instead of `"`. marked passes the entities through verbatim (its tokens carry the raw text, not HTML- escaped output), and our renderer rightly hands that to the terminal unchanged. Terminals don't render entities, so they leak as visible `"` / `&` / `<` etc. This is a known LLM artifact: models sometimes HTML-escape inside code blocks, especially on JSON / HTML / XML output, because their training saw a lot of HTML-encoded code in web posts and docs. Both Claude Code and Cursor decode entities at the rendering boundary; doing the same here. Scope: only code blocks and inline code spans (the contexts where models leak entities the most). Prose paragraphs are left alone — if someone genuinely writes "use the `&` entity to escape ampersand" in non-code text, the entity name stays visible. Numeric forms (`"` / `"`) and the five common named forms (quot / apos / amp / lt / gt / nbsp) decode; unknown names pass through so we don't corrupt prose that quotes entity names. Closes #657
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
…sengine#658) The reporter showed a JSON snippet rendered as `{ "apiKey": "..." }` inside a code fence — the model emitted literal HTML entities instead of `"`. marked passes the entities through verbatim (its tokens carry the raw text, not HTML- escaped output), and our renderer rightly hands that to the terminal unchanged. Terminals don't render entities, so they leak as visible `"` / `&` / `<` etc. This is a known LLM artifact: models sometimes HTML-escape inside code blocks, especially on JSON / HTML / XML output, because their training saw a lot of HTML-encoded code in web posts and docs. Both Claude Code and Cursor decode entities at the rendering boundary; doing the same here. Scope: only code blocks and inline code spans (the contexts where models leak entities the most). Prose paragraphs are left alone — if someone genuinely writes "use the `&` entity to escape ampersand" in non-code text, the entity name stays visible. Numeric forms (`&esengine#34;` / `"`) and the five common named forms (quot / apos / amp / lt / gt / nbsp) decode; unknown names pass through so we don't corrupt prose that quotes entity names. Closes esengine#657
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 4 PR 4.1 from #28. Five panels move out of dashboard/app.js:
panels/overview.ts(53 LoC) — Live Cockpit metric gridpanels/tools.ts(71 LoC) — registered-tools tablepanels/permissions.ts(169 LoC) — allowlist CRUD + builtin groupings; privategroupByVerbhelper folded inpanels/plans.ts(104 LoC) — archived-plan browser + step viewpanels/hooks.ts(105 LoC) — JSON editor for project + global hooksPlus shared pieces these panels need:
components/metric-card.ts(23 LoC) — used by overview now and by system in a later PRlib/html.ts(4 LoC) — singlehtm.bind(h)export so panels don't each rebinddashboard/app.jsloses 419 LoC. Bundle holds at ~122 KB; CDN imports stay external. No behavior change.Closes part of #28.