refactor(dashboard): extract api()/TOKEN/MODE → src/lib/api.ts#32
Merged
Conversation
Stage 3 of #28, PR 3.1. The fetch wrapper (token-on-url for reads, header-too for mutations, JSON parsing, structured ApiError) was the next leaf-y piece after the formatters. Used by every panel, no Preact dependency, easy to type. - dashboard/src/lib/api.ts (new) — typed exports: TOKEN, MODE ("standalone" | "attached"), ApiOptions, ApiError, api<T>(). - dashboard/app.js — drops the inline definitions (~30 lines), imports the named exports. Bundle still passes through tsup unchanged at the byte level (esbuild inlines the lib module into a single file as before). 1682/1682 tests still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3 of #28, PR 3.1. Pulls the fetch wrapper (token-on-url for reads, header-too for mutations, JSON parsing, structured
ApiError) into a typed leaf module. Used by every panel, no Preact dependency.Net: dashboard/app.js loses ~30 LoC, dashboard/src/lib/api.ts (new) replaces it with named typed exports (
TOKEN,MODE,ApiOptions,ApiError,api<T>()).Bundle output unchanged byte-wise (esbuild inlines as before). 1682/1682 tests pass.
Closes part of #28.