[codex] Show status bar amounts in RMB#4485
Closed
jiaxindeyang-a11y wants to merge 2 commits into
Closed
Conversation
This was referenced Jun 15, 2026
Collaborator
|
Thanks @jiaxindeyang-a11y. We are closing this PR as superseded by #4329, which is now the canonical integration route for the cost/currency/status-bar work. Your contribution is recorded in #4329: you normalized the desktop status bar, wallet balance, ContextPanel, and cost-breakdown display around RMB so spend and balance readouts stay consistent. You are acknowledged in #4329 as a repository co-contributor for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatMoneybehavior unchanged for places that intentionally need source-currency formatting.Root Cause
The desktop UI mixed display paths: status bar cost readouts used the session currency from usage events, wallet balance used the backend-provided display string, and the right workbench context panel still formatted its session cost with the original panel currency. That allowed spend to show as
$...while balance showed as¥....Validation
npx.cmd tsx src/__tests__/context-panel-breakdown.test.tsnpm.cmd testnpm.cmd run test:typecheckwas attempted earlier on this branch but still fails locally becausedesktop/frontend/wailsjsis not generated in this checkout (Cannot find module '../../wailsjs/go/main/App').