Skip to content

Reserve mac tabbar new button slot / 预留 mac 标签栏新建按钮槽位#4433

Merged
esengine merged 1 commit into
main-v2from
fix/mac-tabbar-new-button-space
Jun 15, 2026
Merged

Reserve mac tabbar new button slot / 预留 mac 标签栏新建按钮槽位#4433
esengine merged 1 commit into
main-v2from
fix/mac-tabbar-new-button-space

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the macOS tabbar new-session button in the flowing tab strip instead of pinning it as a fixed chrome tool.
  • Reserve a stable new-button slot by subtracting the button width from themed AppChrome tab-list max width.
  • Add a focused AppChrome regression test so the tab list cannot consume the new-button slot again.

Root Cause

After the command search button was pinned as a fixed chrome tool, themed AppChrome still let .tabbar__tabs use max-width: 100%. With enough tabs, the scrollable tab list consumed the whole tabbar width and pushed the flowing new-session button under the fixed search button.

Solution

The tab list remains scrollable, the new-session button still follows the rightmost visible tab, and the themed chrome tab list now reserves the new-button slot before the fixed search area.

Verification

  • npm run check:css
  • npx tsx src/__tests__/app-chrome-tabs.test.ts
  • git diff --check origin/main-v2...HEAD

@SivanCola SivanCola requested a review from esengine as a code owner June 15, 2026 03:47
@github-actions github-actions Bot added desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development labels Jun 15, 2026
@esengine esengine merged commit 2bd8b5d into main-v2 Jun 15, 2026
14 checks passed
@esengine esengine deleted the fix/mac-tabbar-new-button-space branch June 15, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants