Reserve mac tabbar new button slot / 预留 mac 标签栏新建按钮槽位#4433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
After the command search button was pinned as a fixed chrome tool, themed AppChrome still let
.tabbar__tabsusemax-width: 100%. With enough tabs, the scrollable tab list consumed the whole tabbar width and pushed the flowing new-session button under the fixed search button.Solution
The tab list remains scrollable, the new-session button still follows the rightmost visible tab, and the themed chrome tab list now reserves the new-button slot before the fixed search area.
Verification
npm run check:cssnpx tsx src/__tests__/app-chrome-tabs.test.tsgit diff --check origin/main-v2...HEAD