Skip to content

Fix chrome tabs reserving right dock space / 修复顶部标签栏右侧预留空间#4422

Merged
esengine merged 1 commit into
main-v2from
fix/chrome-tabs-reserve-right-dock
Jun 15, 2026
Merged

Fix chrome tabs reserving right dock space / 修复顶部标签栏右侧预留空间#4422
esengine merged 1 commit into
main-v2from
fix/chrome-tabs-reserve-right-dock

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Reserve the right dock/toggle width before rendering the desktop chrome tab strip.
  • Keep native tab padding consistent across themed macOS, Windows, Linux, and browser-preview chrome styles.
  • Add a focused regression test that verifies chrome tab selectors include the right-dock offset.

Root Cause

The chrome layout exposes a right-dock offset, but several native/tab chrome padding rules and theme overrides did not include it. When the right dock was open, the tab strip could continue laying out into the reserved right-side area.

Verification

  • npm run check:css
  • npx tsx src/__tests__/app-chrome-tabs.test.ts
  • git diff --check

@SivanCola SivanCola requested a review from esengine as a code owner June 15, 2026 03:15
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 15, 2026
@esengine esengine merged commit 7f2cea2 into main-v2 Jun 15, 2026
14 checks passed
@esengine esengine deleted the fix/chrome-tabs-reserve-right-dock branch June 15, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants