Fix desktop diff row rendering and summaries / 修复桌面端 diff 行渲染和摘要#4387
Merged
Conversation
Render diff rows against a shared scroll width, add old/new line gutters for full and inline diffs, and persist writer summaries before tool data archiving. Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e38a1da37d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Clear cached writer summaries on failed tool results and defer replace-all multi_edit summaries until the backend result reports the actual replacement count. Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
Resolve the frontend test script conflict by preserving the main-v2 todo/history tests and this PR's diff-rendering regression coverage. Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
Collaborator
Author
|
Updated this PR in 444a761 and resolved the conflicts with Conflict resolution:
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+N -Medit summary.Verification
pnpm --dir desktop/frontend testpnpm --dir desktop/frontend typecheckpnpm --dir desktop/frontend test:typecheckpnpm --dir desktop/frontend check:csspnpm --dir desktop/frontend buildFixes #4382