Skip to content

Document desktop hooks usage / 补充桌面端 Hooks 使用说明#4373

Merged
esengine merged 2 commits into
main-v2from
docs/desktop-hooks-guide
Jun 14, 2026
Merged

Document desktop hooks usage / 补充桌面端 Hooks 使用说明#4373
esengine merged 2 commits into
main-v2from
docs/desktop-hooks-guide

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a Chinese desktop Hooks guide covering settings scopes, project trust, JSON shapes, event keys, stdin payload fields, exit-code behavior, and examples.
  • Correct Hooks reload guidance so docs, desktop settings copy, and /hooks trust notices no longer claim /new reloads saved hook config.
  • Link the new guide from the Chinese usage guide.

Tests

  • go test ./internal/hook ./internal/control ./internal/cli
  • cd desktop && go test . -run 'Test(SaveHooksSettingsPreservesUnknownSettingsKeys|ProjectHooksSettingsUseActiveWorkspaceRootAndTrust|TrustProjectHooksForRootUsesDisplayedProjectRoot|SaveHooksSettingsForRootUsesDisplayedProjectRoot)'
  • cd desktop && wails generate module
  • pnpm --dir desktop/frontend typecheck

@SivanCola SivanCola requested a review from esengine as a code owner June 14, 2026 10:58
@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jun 14, 2026
@SivanCola SivanCola enabled auto-merge June 14, 2026 10:59
@SivanCola

Copy link
Copy Markdown
Collaborator Author

approve

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c5861ff5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/DESKTOP_HOOKS.zh-CN.md Outdated
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@github-actions github-actions Bot added desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) agent Core agent loop (internal/agent, internal/control) labels Jun 14, 2026
@esengine esengine merged commit 6e798bc into main-v2 Jun 14, 2026
15 checks passed
@esengine esengine deleted the docs/desktop-hooks-guide branch June 14, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants