Skip to content

Improve crash stats dashboard UI / 优化崩溃统计面板 UI#4325

Merged
esengine merged 5 commits into
esengine:main-v2from
SivanCola:feature/stats-chart-axis-tooltips
Jun 14, 2026
Merged

Improve crash stats dashboard UI / 优化崩溃统计面板 UI#4325
esengine merged 5 commits into
esengine:main-v2from
SivanCola:feature/stats-chart-axis-tooltips

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Add a header language switcher for Chinese and English, persisted locally in the browser.
  • Add y-axis tick labels, gridlines, and wider hover targets to the daily active installs chart.
  • Redesign crash filters into grouped status and facet chips that handle long version labels cleanly.
  • Redesign crash groups as row-level clickable diagnostic cards with clearer scope, health, and count columns.
  • Redesign crash group detail pages with a compact summary header, key metrics, collapsible samples, copy actions, and a tighter admin management layout.

Verification

  • Worker TypeScript typecheck passed.
  • git diff --check passed.
  • Verified the stats dashboard and crash group detail page in the in-app browser with local previews.
  • Verified Chinese/English switching, sample expansion, row-level navigation targets, and copy-button success/failure states.

Cache impact

  • No prompt-cache or provider-visible request surface changes; this only affects the crash stats Worker UI.

@SivanCola SivanCola requested a review from esengine as a code owner June 13, 2026 18:53
@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jun 13, 2026
@SivanCola SivanCola force-pushed the feature/stats-chart-axis-tooltips branch from fc71e54 to 8881e44 Compare June 13, 2026 19:19
@SivanCola SivanCola changed the title Add stats chart axis labels and hover targets / 为统计图表增加纵轴刻度和悬停数值 Improve crash stats dashboard UI / 优化崩溃统计面板 UI Jun 13, 2026
@esengine

esengine commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Reviewed — the dashboard redesign reads well and the escaping is consistent: every report-derived field is esc()'d (versions, titles, samples, copy-button payloads) and breadcrumbs reuse the existing helper, so no XSS regression.

One thing before it can land: this conflicts with main-v2 because #4322 relabeled the dashboard from "Crash / 崩溃" to "Report / 诊断", and this branch predates that. Could you merge main-v2 and reconcile? Since you authored both, it's your call whether the redesign keeps the "diagnostic / 诊断" framing. Once it's green I'll merge.

@SivanCola
Merge main-v2 into stats dashboard UI
5af5e72 
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
@SivanCola SivanCola enabled auto-merge June 14, 2026 13:38
@SivanCola

SivanCola commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

Addressed in b1b6e65.

What changed:

  • Merged the latest main-v2 into this PR branch.
  • Kept the stats dashboard on the Report / diagnostic framing and cleaned the remaining dashboard-facing copy to say diagnostic reports / report data instead of crash dashboard / crash data.

Verified:

  • npm --prefix workers/crash-report run typecheck
  • go test -race ./internal/control
  • GitHub CI is green for this head, including race.

@esengine esengine merged commit 424f33f into esengine:main-v2 Jun 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esengine esengine Awaiting requested review from esengine esengine is a code owner

Assignees

No one assigned

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SivanCola @esengine