Add PermissionRequest hook for tool approvals / 新增工具审批 PermissionRequest Hook#4319
Merged
esengine merged 2 commits intoJun 14, 2026
Merged
Conversation
This was referenced Jun 13, 2026
3362c45 to
e542da6
Compare
Collaborator
Author
|
@codex review |
Collaborator
Author
|
approve |
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
e542da6 to
fcf37fc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e542da6388
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: SivanCola <32437197+SivanCola@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3661.
Related: #3855.
This PR keeps the scope limited to the
PermissionRequesthook from #3855. The separatemove_filework remains in #4316 and is intentionally outside this PR.Authorship note
@AresNing is the primary author of the
PermissionRequesthook implementation originally proposed in #3855. @SivanCola contributed as a collaborator by rebasing it onto the currentmain-v2, resolving integration conflicts, adding explicit regression coverage for prompt-triggered and non-triggering paths, and verifying the scoped PermissionRequest state.What changed
PermissionRequestto the hook event list, default timeout handling, tool-name matching, hook payload, runner, CLI hook view, and example config.PermissionRequestonly when a real tool approval prompt is emitted; policy allow, session grants, auto/yolo approval, and plan approval do not trigger it.Validation
go test ./internal/boot ./internal/cli ./internal/control ./internal/hookgo test ./...git diff --check origin/main-v2..HEAD