Skip to content

Fix reasoning language propagation / 修复思考语言设置传播#4312

Merged
esengine merged 2 commits into
main-v2from
fix/reasoning-language-runtime-propagation
Jun 14, 2026
Merged

Fix reasoning language propagation / 修复思考语言设置传播#4312
esengine merged 2 commits into
main-v2from
fix/reasoning-language-runtime-propagation

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Apply saved reasoning-language changes to all live desktop tab controllers while respecting project-level overrides.
  • Route normal and synthetic user turns through a shared transient <reasoning-language> helper, including plan approval and retry/nudge turns.
  • Pass the reasoning-language runtime preference through agent, planner, direct subagent, and task-subagent paths.

Cache behavior

  • Keeps the preference in transient user-turn context.
  • Does not change the system prompt, tool schemas, tool list, or provider request serialization.

Tests

  • go test ./...
  • (cd desktop && go test .)

@SivanCola SivanCola requested a review from esengine as a code owner June 13, 2026 15:56
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) labels Jun 13, 2026
@SivanCola SivanCola enabled auto-merge June 13, 2026 16:01
@SivanCola

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23fee04678

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/boot/boot.go Outdated
Comment thread internal/agent/reasoning_language.go Outdated
Comment thread internal/control/controller.go Outdated
@SivanCola

Copy link
Copy Markdown
Collaborator Author

approve

@esengine esengine merged commit 61bb5c8 into main-v2 Jun 14, 2026
13 checks passed
@esengine esengine deleted the fix/reasoning-language-runtime-propagation branch June 14, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants