Skip to content

Add reasoning language settings / 添加思考语言设置#4267

Merged
esengine merged 4 commits into
main-v2from
feature/agent-reasoning-language
Jun 13, 2026
Merged

Add reasoning language settings / 添加思考语言设置#4267
esengine merged 4 commits into
main-v2from
feature/agent-reasoning-language

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • add agent.reasoning_language with visible options auto, zh, and en
  • apply zh/en as transient per-turn context while auto injects no additional language instruction
  • expose the setting in Desktop Settings and refine the Agent runtime copy, tooltip behavior, model usage layout, and step-limit order
  • document the new config option and add focused config, render, input, and desktop settings coverage

Cache behavior

  • auto keeps the existing stable language policy and does not add dynamic content
  • explicit language preferences are composed into the user turn, not the stable system prompt or tool schema

Validation

  • pnpm --dir desktop/frontend check:css
  • pnpm --dir desktop/frontend typecheck
  • pnpm --dir desktop/frontend test:all
  • go test ./internal/config ./internal/control ./internal/boot ./internal/i18n
  • go test ./... in desktop/
  • verified the Settings > Models > Usage UI in the in-app browser

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) labels Jun 13, 2026
@SivanCola SivanCola marked this pull request as ready for review June 13, 2026 07:27
@SivanCola SivanCola requested a review from esengine as a code owner June 13, 2026 07:27
@SivanCola SivanCola enabled auto-merge June 13, 2026 07:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1665f6a490

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/control/input.go
Comment thread internal/control/input.go
Comment thread internal/control/input.go
@SivanCola

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c41473b53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/control/input.go
@github-actions github-actions Bot added the tui Terminal UI / CLI (internal/cli, internal/control) label Jun 13, 2026
@esengine esengine merged commit f6d8cce into main-v2 Jun 13, 2026
13 checks passed
@esengine esengine deleted the feature/agent-reasoning-language branch June 13, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants