Skip to content

Compact settings sound controls / 收紧设置页声音控件#4244

Merged
esengine merged 1 commit into
main-v2from
feature/compact-settings-sound-controls
Jun 13, 2026
Merged

Compact settings sound controls / 收紧设置页声音控件#4244
esengine merged 1 commit into
main-v2from
feature/compact-settings-sound-controls

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Compact the General settings sound controls into one collapsed Sound row with a short status badge.
  • Move background music and notification sound selectors into an expandable three-row list.
  • Hide preview buttons when a sound is off, use the shared Play icon, and add responsive styling to avoid narrow-window overflow.
  • Add English, Simplified Chinese, and Traditional Chinese strings for the new Sound row.

Validation

  • npm --prefix desktop/frontend run typecheck
  • npm --prefix desktop/frontend run check:css
  • git diff --check
  • Browser verification: collapsed status badge, expanded three-row sound list, and 390px viewport without horizontal overflow.

Related

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 13, 2026
@SivanCola SivanCola force-pushed the feature/compact-settings-sound-controls branch from e8184a1 to e37426f Compare June 13, 2026 04:49
@SivanCola SivanCola marked this pull request as ready for review June 13, 2026 04:52
@SivanCola SivanCola requested a review from esengine as a code owner June 13, 2026 04:52
@SivanCola

Copy link
Copy Markdown
Collaborator Author

@codex review

@esengine esengine merged commit 89bfa96 into main-v2 Jun 13, 2026
13 checks passed
@esengine esengine deleted the feature/compact-settings-sound-controls branch June 13, 2026 04:56
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: e37426fb05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants