fix(desktop): stop clipping the tool name in the card header#4208
Merged
Conversation
tool__label-group was capped at max-width:70% with overflow:hidden, so a non-shrinking tool name was hard-cut (e.g. a sub-agent "explore" rendered as "explor") once the ⊞count + status icon + name reached the cap with no subject to absorb the overflow. Let the group shrink as a flex unit instead — the subject keeps ellipsizing, the name stays whole — and pin the duration so a long subject can't squeeze it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4206. After the status icon +
⊞count moved intotool__label-groupleft of the name, that group'smax-width: 70%+overflow: hiddenhard-cut the (non-shrinking) tool name whenever icons + name reached the cap with no subject to absorb the overflow — a sub-agentexplorecard rendered asexplor,researchasresea…-with-no-ellipsis.Fix: drop the fixed cap + hard clip on the group and let it shrink as a flex unit (
flex: 0 1 auto). The subject keeps ellipsizing via its own rule, the name stays whole, andtool__durationis pinned (flex-shrink: 0) so a long subject can't squeeze it out. In an extreme-narrow card the chevron clips before the name now, which is the right priority.Verified
pnpm --dir desktop/frontend check:cssgreen.