fix(desktop): make the time-filter menu keyboard-operable#4197
Merged
Conversation
Follow-up to #4150. The dropdown is marked up as role=menu/menuitem but was mouse-only. Add Escape-to-close (focus returns to the trigger), move focus into the menu on open (the selected option, else the first), and ArrowUp/Down/Home/End roving between options. The trigger gains aria-haspopup / aria-expanded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4150. The time-filter dropdown is marked up as
role=menu/menuitembut was mouse-only.aria-haspopup/aria-expanded.No behaviour change for mouse users (programmatic focus after a click doesn't trip the
:focus-visiblering).