fix(desktop): right-align the sidebar time-filter menu so it can't clip#4196
Merged
Conversation
Follow-up to #4150. The dropdown was positioned `left: 0` inside the `overflow: hidden` sidebar; the trigger sits in the right-aligned header, so on a narrow sidebar — and with the longer zh labels — the menu ran past the right edge and got clipped. Right-align it so it opens leftward into the sidebar. Also fold the duplicated Latest-10 / Latest-20 cutoff IIFEs into one helper; behavior is identical (same Set-dedup, sort, and short-list fallback).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4150 (the codex bot flagged the same thing).
The time-filter dropdown was
left: 0inside theoverflow: hiddensidebar; the trigger is in the right-aligned header, so on a narrow sidebar — and with the longer zh labels — the menu ran past the right edge and clipped. Right-align it so it opens leftward into the sidebar.Also folds the duplicated Latest-10 / Latest-20 cutoff IIFEs into one helper, behavior-identical (same Set-dedup, sort, short-list fallback).