Skip to content

feat(desktop): token-driven generative ambient music (rebased #4175)#4192

Merged
esengine merged 1 commit into
main-v2from
pr/4175-generative-music-rebased
Jun 12, 2026
Merged

feat(desktop): token-driven generative ambient music (rebased #4175)#4192
esengine merged 1 commit into
main-v2from
pr/4175-generative-music-rebased

Conversation

@esengine

Copy link
Copy Markdown
Owner

Lands #4175 (token-driven generative ambient music in the desktop app) on current main-v2.

Squashed onto main-v2 (the original PR had merged main-v2 back in and #4188 had since moved SettingsPanel.tsx), plus a house-style comment pass on generative-music.ts / App.tsx — trimmed the multi-line file header, dropped the // ── … ── section banners and the restating one-liners, keeping only the non-obvious why (pentatonic scale, the double throttle, the wet gain). No behaviour change: the code lines are byte-identical to #4175.

Credit to @ttmouse for the feature and @SivanCola for the review fixes (default-off + live preset/stop sync), both folded into the single commit here.

What it does

  • Opt-in, default off. Preset picker in Settings → General (classic / ethereal / digital / retro).
  • Each text/reasoning/tool token triggers a C-major-pentatonic note through a Web Audio chain (oscillator → ADSR → low-pass → reverb); fast generation → denser notes.
  • Throttled (every 4th token + 100 ms floor) for DeepSeek's output rate.
  • Switching to Off or another preset mid-generation takes effect immediately; nothing auto-plays on launch/upgrade.

Verification (local)

  • pnpm --dir desktop/frontend typecheck — clean apart from the usual ungenerated-wailsjs binding errors that wails generate resolves in CI.
  • go build ./... in desktop/ — green.
  • Confirmed the cleanup is comment-only (PR-original vs. cleaned: code lines identical).

Closes #4175

Opt-in, default off; preset picker in Settings -> General. Maps the
generation token stream to a pentatonic Web Audio voice (osc -> ADSR ->
low-pass -> reverb) so a long silent wait has audible "still working"
feedback. Throttled (every 4th token, 100ms floor) for DeepSeek's rate.
@esengine esengine requested a review from SivanCola as a code owner June 12, 2026 13:23
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 12, 2026
@esengine esengine merged commit 50294fa into main-v2 Jun 12, 2026
14 checks passed
@esengine esengine deleted the pr/4175-generative-music-rebased branch June 12, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants