Skip to content

docs(crash): disclose Go-panic resend in telemetry copy#4191

Merged
esengine merged 1 commit into
main-v2from
fix/crash-telemetry-disclosure
Jun 12, 2026
Merged

docs(crash): disclose Go-panic resend in telemetry copy#4191
esengine merged 1 commit into
main-v2from
fix/crash-telemetry-disclosure

Conversation

@esengine

Copy link
Copy Markdown
Owner

Follow-up to #4187. That PR added an automatic resend of a Go-side panic
captured on a prior run, gated on the same desktop.telemetry opt-out as the
launch ping. Two copy surfaces still claimed only the ping / only user-sent
crashes were collected:

  • Settings hint (settings.telemetryHint, en + zh) — the toggle now also
    controls the prior-run crash resend, so the hint says so. The "never includes
    conversations, keys, or file contents" guarantee is unchanged.
  • Dashboard /stats line — dropped "user-sent ... only", since the list
    now includes Go crashes resent on next launch as well.

Copy only; no behavior change.

The desktop.telemetry toggle now also gates resending a crash captured on a
prior run (the Go-side panic path), and the dashboard lists those alongside
user-sent reports. Update the settings hint (en/zh) and the /stats line so the
copy matches what's actually collected — "user-sent ... only" is no longer true.
@esengine esengine requested a review from SivanCola as a code owner June 12, 2026 13:19
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 12, 2026
@esengine esengine merged commit 6a693eb into main-v2 Jun 12, 2026
14 checks passed
@esengine esengine deleted the fix/crash-telemetry-disclosure branch June 12, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant