fix(desktop): reveal files via explorer.exe's full path, not a PATH lookup#4137
Merged
Conversation
…ookup
"Reveal in file manager" ran `exec.Command("explorer", ...)`, relying on
explorer being on PATH. On Windows installs whose launch environment doesn't
include %SystemRoot% on PATH, that fails with `exec: "explorer": executable
file not found in %PATH%`, and because the two frontend callers fire the
promise with a bare `void` (no catch), it surfaced as an [unhandledrejection]
in crash telemetry.
Resolve explorer.exe directly from %SystemRoot% (then %windir%), and catch the
reveal promise at both call sites so a failed reveal can never become an
unhandled rejection again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crash
Three crash-telemetry reports on Windows v1.6.0, all the same:
Cause
revealPath("Reveal in file manager") ranexec.Command("explorer", "/select,", path), which does a PATH lookup.explorer.exelives in%SystemRoot%(C:\Windows), and on installs whose launch environment doesn't carry%SystemRoot%on PATH the lookup fails. The two frontend callers fire the call with a barevoid app.RevealPath(...)— no.catch— so the rejected promise became an[unhandledrejection]and got reported as a crash.Fix
explorer.exedirectly from%SystemRoot%(then%windir%), mirroring theSystemRoot/windirresolution already used insandbox/shell.go. Falls back to the bare name if neither is set..catch(() => {})at both reveal call sites (ProjectTree,WorkspacePanel) so any future reveal failure (deleted path, etc.) degrades silently instead of crash-reporting.cd desktop && go build ./... && go vet .clean; gofmt clean. Frontend change is a one-token.catchat each site (no new bindings/types).