feat(desktop): add a Shell interpreter dropdown to Settings → Sandbox#4134
Merged
Conversation
Surfaces the [tools.shell] preference (added in #4131) in the desktop Settings panel so users don't have to hand-edit reasonix.toml. The Sandbox tab gains a "Shell interpreter" select — auto / bash / PowerShell / pwsh — wired through the existing SetSandbox apply path (snapshot → reload → resume), with en/zh strings. Closes #4114
557a8a8 to
d4d2be4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4114. Follow-up to #4131 (the
[tools.shell]config), adding the desktop Settings → Sandbox UI so users don't have to hand-editreasonix.toml.Change
auto/bash/PowerShell/pwsh.SetSandboxapply path (snapshot → reload → resume, same live-apply as the other sandbox settings), reading/writing[tools.shell] prefer.SandboxView(Go) gains aShellfield;bridge.tsAppBindings interface + dev mock + default view updated to match; en/zh strings added.The TS
SandboxView/SettingsViewtypes are wails-generated from the Go structs, so the newshellfield is picked up bywails generateon CI.Verified
cd desktop && go build ./... && go test ./ -run 'Settings|Sandbox'green; gofmt clean.