feat(desktop): build the Windows ARM64 desktop app#4128
Merged
Conversation
Add a windows/arm64 target to the desktop release matrix on a native windows-11-arm runner — Wails can't cross-compile its CGO+WebView binary, so each arch builds on its own runner. Teach the manifest generator the windows-arm64 key and skip the portable .zip for any windows- arch, not just amd64. The build script is already arch-parameterized and the updater's CurrentPlatform already resolves windows-arm64, so nothing else changes. The arm64 build only runs on a desktop-v* tag or a manual dispatch, so PR CI does not exercise it; the next desktop release validates the runner toolchain. fail-fast is already off, so an arm64 failure won't sink the other platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Windows on ARM64 build of the desktop app, for Snapdragon / Windows-ARM devices.
What changed
windows/arm64target on a nativewindows-11-armrunner. The build script already notes Wails can't cross-compile its CGO+WebView binary, so each arch builds on its own native runner; this just adds the missing one (GitHub'swindows-11-armrunner is GA for public repos).desktop/cmd/sign) — added thewindows-arm64platform key and generalized the portable-.zipskip to anywindows-arch, so the updater channel stays the per-arch-installer.exe.Nothing else needed changing:
scripts/desktop-build.shis already arch-parameterized (Reasonix-windows-arm64-installer.exe, etc.).CurrentPlatform()isGOOS-GOARCH, so an arm64 build already resolveswindows-arm64.codegraph-win32-arm64.zip.Validation
cd desktop && go test ./cmd/signpasses, including new coverage thatReasonix-windows-arm64-installer.exemaps towindows-arm64and the portable.zipis skipped.darwin-universal, windows-amd64, windows-arm64, linux-amd64.Note
The desktop build job only runs on a
desktop-v*tag or a manualworkflow_dispatch, so PR CI does not exercise the arm64 build — the first desktop release (or a canary dispatch) validates the runner toolchain (Wails + WebView2 + NSIS + cgo on ARM64).fail-fast: falseis already set, so an arm64 build failure won't sink the other platforms; the manifest simply omits the arm64 key if its artifact is missing.The CLI already supports Windows ARM64 today (
reasonix@next→@reasonix/cli-win32-arm64); this brings the desktop app to parity.