refactor(ui): keep running read-only tools out of the warm-turn batch#4032
Merged
Conversation
WarmTurnItems batched read-only tools without the status guard the hot-zone and TurnCollapse paths use. Add it for consistency so an interrupted running tool lingering in history renders individually instead of folding into the batch. Drop a stray blank line. Follow-up to #4031.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4031.
TurnCollapseread-only batch paths skip tools withstatus === "running"(they render individually with the shimmer);WarmTurnItemsbatched read-only tools without that guard. Addit.status !== "running"so an interrupted running tool lingering in a warm turn renders individually instead of folding silently into the batch. No-op for normal history (warm turns are complete).TurnCollapseclose brace.