refactor(evidence): reuse stepTextContains for todo overlap, hoist bounds guard#4027
Merged
Merged
Conversation
…unds guard textOverlaps duplicated stepTextContains verbatim — fold it into a normalize-then-contains one-liner. Hoist the index bounds check so both current[index-1] accesses share one guard instead of one inline and one bare. Follow-up to #4013; behavior unchanged (evidence tests pass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4013 (no behavior change;
internal/evidencetests pass unchanged).stepTextContains.textOverlapswas a verbatim copy ofstepTextContains(fix(evidence): tolerate citation drift when matching complete_step to todos #4006) with normalization folded in. Replace its body withstepTextContains(normalizeStepText(a), normalizeStepText(b))— drops ~15 duplicated lines.hasSuccessfulCompleteStepForTodoguardedindexinline on thesameTodoMatchline but accessedcurrent[index-1]unguarded in the new overlap branch. Move theindexrange check to the top of the block so both accesses share one guard.