fix(ui): restrict inverted user bubble style to graphite theme only#4023
Conversation
SivanCola
left a comment
There was a problem hiding this comment.
Thanks for the CSS fix here. Narrowing the user-bubble selector to data-theme-style="graphite" looks right to me; the non-graphite themes still have the base/shared .msg--user .msg__body styling as fallback.
The blocker is the dev change. This PR is now dirty against main-v2: #4024 already changed the same pnpm guard block and added desktop/frontend/.npmrc for the Wails headless pnpm case. Please rebase and keep the current base behavior there.
In particular, please do not resolve the conflict by using export pnpm_confirm_modules_purge=false. That env var form is missing the config part and does not match the pnpm config env convention. The current base uses npm_config_confirm_modules_purge=false plus npm_config_minimum_release_age=0, with .npmrc covering confirm-modules-purge=false and verify-deps-before-run=false.
So I think the mergeable shape should be: keep the CSS selector fix, drop/reconcile the dev change with the latest main-v2 pnpm guard.
5b976d5 to
cc7237b
Compare
The rule :root[data-theme-style] .msg--user .msg__body (with no specific style value) leaked graphite's inverted-color bubble (--fg as background, --bg as text) onto all other themes like carbon, aurora, and slate. Fix: narrow both selectors to [data-theme-style="graphite"].
cc7237b to
5135d7d
Compare
|
Thanks @CVEngineer66 — correct narrowing; the inverted user bubble now only applies under |
[data-theme-style](bare, no value) matched every theme direction — graphite, carbon, aurora, slate — but the rule body uses graphite-specific colors (--fgas background,--bgas text). This turned user chat bubbles inside-out on non-graphite themes:#f8f6f2bg,#1a1714text#1e1c1abg,#ede9e3textFixed by narrowing both selectors to
[data-theme-style="graphite"].Also fixes the pnpm environment variable in
dev: pnpm v11 usespnmp_confirm_modules_purge, notPNPM_CONFIG_CONFIRM_MODULES_PURGE(which is npm's format), so Wails' headless pnpm install was always blocked by the TTY prompt.