fix: Improve desktop context status metrics#3996
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82aa54acbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tightens the desktop UI metrics shown around chat context and token usage. The main user-facing areas touched are the bottom status bar and the right-side Context overview panel.
Bottom status bar
turnTotalTokensstate value so it reflects the total tokens reported for the current or most recent exchange, rather than reusing the existing completion-onlyturnTokensvalue used by the composer.Context overview donut
usedTokens / windowTokens) rather than provider/session totals. This prevents cases like61k / 1000k = 6%visually rendering as an almost-full ring.Tests
context-panel-breakdown.test.tsto lock the context donut math. The test covers reasoning not being double-counted and oversized provider breakdown values not filling the ring.Verification
pnpm exec tsx src/__tests__/context-panel-breakdown.test.tspnpm run typecheckpnpm run test:typecheckNotes
.codex/anddesigns/directories were left out of this PR.