Skip to content

Prompt only for active model keys / 仅提示活跃模型密钥#3976

Merged
SivanCola merged 2 commits into
esengine:main-v2from
SivanCola:fix/active-key-prompts
Jun 11, 2026
Merged

Prompt only for active model keys / 仅提示活跃模型密钥#3976
SivanCola merged 2 commits into
esengine:main-v2from
SivanCola:fix/active-key-prompts

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • resolve active missing-key prompts through the normal model resolver instead of matching provider names directly
  • include auto_plan_classifier and deterministic subagent model ordering in the active key scan
  • add regression coverage for DeepSeek-only startup, unused MiMo presets, and explicitly referenced MiMo secondary models
  • isolate rewind tests from global CLI language state

Testing

  • go test ./internal/cli -count=1

Refs #3939

@SivanCola SivanCola requested a review from esengine as a code owner June 11, 2026 07:02
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development tui Terminal UI / CLI (internal/cli, internal/control) labels Jun 11, 2026
@SivanCola SivanCola enabled auto-merge June 11, 2026 07:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a8627e391

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/cli/cli.go Outdated

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolving through the model resolver instead of name-matching is the right fix — the old code silently missed provider/model refs entirely, and the unused-preset prompts were pure noise. Nice touches: the deterministic subagent-model ordering, dedup by key env, and the auto_plan gate matching boot.go's idiom. The rewind-test locale isolation is appreciated too. Thanks!

@SivanCola SivanCola merged commit 5debb08 into esengine:main-v2 Jun 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants