fix(chat): repaint late-collapsed tool slots immediately#3973
Merged
Conversation
Follow-up to #3951: the late-result branch of collapseToolOutput mutated the transcript without setting transcriptDirty, so the rewritten slot waited for the next unrelated event to paint. Set the flag inside collapseShellSlot, covering both callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3951 (cross-posted there): the late-result branch of
collapseToolOutputmutates the transcript and returns without settingtranscriptDirty, so a late-collapsed slot doesn't repaint until the next unrelated event arrives. Moved the flag intocollapseShellSlotso both callers are covered, and dropped the now-redundant set in the active path.