fix(desktop): make the macOS tab-strip empty space drag the window#3963
Merged
Conversation
The darwin chrome blanket-marks the whole tabbar no-drag and leaves only a 10px rail at the very top as the drag region, so dragging the visible titlebar area selects text instead of moving the window. Re-enable drag on the spacer between the last tab and the search button and stretch it to the strip height -- the area every user actually grabs. Closes #3853 Closes #3852
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro (#3853 / #3852, drag half of #3843): on macOS 1.5.0 the titlebar doesn't drag the window — dragging over the tab strip selects text instead.
Cause: the darwin chrome blanket-marks the entire tab strip and every tabbar descendant
--wails-draggable: no-drag, leaving a 10px-tall "drag rail" at the very top of the 44px header as the only drag region. Nobody aims for a 10px sliver; everyone grabs the visible empty strip next to the tabs, which is the no-drag spacer.Fix: re-enable
--wails-draggable: dragon.tabbar__spacer(the flexible empty area between the last tab and the search button) andalign-self: stretchit to full strip height. Tabs, the new-tab button, and the search button stay no-drag, so tab interactions are unaffected. The top rail is kept as an additional region.The "Auto/YOLO 时金额边上文字重叠" part of #3843 is a separate rendering issue I couldn't reproduce from the code alone — leaving that issue open.
Needs a visual confirm on a real mac before release.
Closes #3853
Closes #3852