fix(desktop): stop pinning management modals to a compositor layer#3961
Merged
Conversation
will-change: transform plus a fill-mode that keeps the final transform applied left the settings/history/trash modal permanently composited, rasterized at the entrance-animation scale. On Windows fractional DPI the whole panel rendered blurry until a tab switch or resize forced a repaint. Let the entrance animation end with no retained style so the modal returns to the normal raster path. Closes #3838 Closes #3902 Closes #3899
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro (#3838 / #3902 / #3899): open Settings (or trash / history view) on Windows — all text in the panel renders blurry; it snaps crisp after clicking another tab or resizing the window.
Cause:
.management-modalcarriedwill-change: transform, opacityplus an entrance animation withfill-mode: bothwhose 100% frame retains a transform (translate3d(0,0,0) scale(1)). Both keep the modal promoted to a compositor layer whose texture was rasterized during the scaled entrance frames; on fractional display scaling (125%/150%) WebView2 then re-samples that texture instead of re-rasterizing, so text stays soft until something forces a repaint — exactly the "clears after clicking a tab / resizing" behavior in the reports.Fix: drop
will-changeand the fill-mode, and end the keyframes attransform: none. The entrance looks identical (no delay, final frame equals the base style), but once it finishes no transform or animation style remains applied, so the layer is demoted and text rasterizes at native DPI.CSS syntax + z-index token checks pass. Needs a quick visual confirm on a Windows 125%/150% scale machine before release.
Closes #3838
Closes #3902
Closes #3899