fix: Ctrl+C in running state copies selection instead of cancelling turn#3947
Merged
Merged
Conversation
esengine
approved these changes
Jun 11, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Exactly right — same selection-first contract as the idle path (and it reuses that path's restore/copy/clear dance verbatim, so the two can't diverge in behavior). Losing an in-flight turn because you tried to copy output was a nasty trap. Merging, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the chat TUI is running (tuiRunning state), selecting text and pressing Ctrl+C should copy the selection to clipboard — same as the idle-state behavior. Instead, it cancels the in-flight turn.
Fix
In the Ctrl+C handler for the tuiRunning state, check for an active text selection first: