fix(desktop): widen model switcher popover for long model names (#3641)#3915
Merged
Conversation
Decouple popover width from trigger width: keep the 160px floor as minWidth and cap growth at 400px so long model refs stay readable. Add title attributes on model/provider labels as a hover fallback. Fixes #3628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #3641 by @0xzqy (zqy) on top of current main-v2 — the original branch conflicted with the post-#3885 popover sizing change.
Conflict resolution: kept the 160px floor that main-v2 added (
minWidth: max(triggerWidth, 160)) while adopting the decoupled growth from the original PR (maxWidth: 400, no fixedwidth), so long model refs widen the popover without regressing the minimum size. Thetitlehover fallbacks and ellipsis CSS land unchanged. Author credit preserved on the commit.Closes #3641
Fixes #3628