Skip to content

Improve context overview navigation and status metrics / 优化会话概览跳转与底部状态指标#3895

Closed
SivanCola wants to merge 3 commits into
main-v2from
feature/context-overview-status-metrics
Closed

Improve context overview navigation and status metrics / 优化会话概览跳转与底部状态指标#3895
SivanCola wants to merge 3 commits into
main-v2from
feature/context-overview-status-metrics

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Redesign the bottom status bar around grouped model/cache/token/context/cost metrics with shared tooltips, value coloring for cache hit rates, and warning states for the compaction threshold.
  • Refresh the right-side context overview by removing duplicated header/project chips, tightening runtime/cost/session cards, and making non-default themes inherit the Graphite layout while keeping their own colors.
  • Add overview-to-workspace navigation: dependency rows and View all open scoped Files lists, while session-change rows and View all open scoped Changes lists and file history.
  • Carry total/session token accounting through desktop telemetry, frontend controller state, and browser development mocks.

Related PRs

Cache safety

  • UI/status-panel only. This does not change provider request serialization, prompt prefixes, tool schemas, or cache-key material.

Verification

  • npm run build
  • go test . -run TestWorkspaceTabAggregatesSessionUsageTelemetry from the desktop module
  • Browser verification on the local development UI for dependency-file reveal, dependency View all, session-change reveal, and session-change View all

@SivanCola SivanCola requested a review from esengine as a code owner June 10, 2026 20:36
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 10, 2026
@SivanCola SivanCola enabled auto-merge June 10, 2026 21:06
@esengine

Copy link
Copy Markdown
Owner

The redesign looks good and the cache-safety note holds — this is UI/status/telemetry only, and the new TotalTokens plumbing is clean and additive (nice that the test asserts both the telemetry aggregate and ContextPanel().TotalTokens).

One coordination item before I approve, on desktop/tabs.go. #3854 just landed and moved the per-turn token breakdown off the cumulative telemetry.Usage onto ctrl.LastUsage() — that was the fix for the donut segments being wrong after turn 1 (snapshot vs cumulative unit mismatch). This branch predates that, so its ContextPanel still assigns the breakdown from usage.PromptTokens/CompletionTokens/..., which would re-break #3854 if it merges on top.

Could you rebase onto the latest main-v2 and resolve it so that:

They're complementary — TotalTokens is additive and doesn't conflict with the snapshot breakdown. The locale/App.tsx files will also pick up conflicts from a few sibling desktop merges, same as the others. Ping me after the rebase and I'll do the full pass + approve. Thanks!

@SivanCola SivanCola force-pushed the feature/context-overview-status-metrics branch from 0aa9f65 to 8d8dd80 Compare June 11, 2026 02:32
@SivanCola

Copy link
Copy Markdown
Collaborator Author

Rebased onto the latest main-v2 and resolved the conflict drift from #3854.

What changed:

  • Kept the ContextPanel per-turn breakdown sourced from ctrl.LastUsage().
  • Added only info.TotalTokens = usage.TotalTokens from cumulative telemetry.Usage.
  • Resolved the sibling desktop/frontend and locale conflicts from the rebase.
  • Added a regression test that keeps cumulative telemetry totals from overwriting the LastUsage breakdown.

Verified:

  • go test . in the desktop module
  • pnpm --dir desktop/frontend build

Ready for another pass when you have time.

@SivanCola SivanCola force-pushed the feature/context-overview-status-metrics branch from 451a542 to fb869f7 Compare June 11, 2026 03:02
@SivanCola

Copy link
Copy Markdown
Collaborator Author

Updated the PR again on top of the latest main-v2.

Additional fix:

  • Fixed the workspace preview close action after opening a dependency file from the Context overview. The revealed file request is now marked as dismissed when the user closes that preview, so the same request does not immediately reopen the file.

Verified:

  • go test . in the desktop module
  • wails generate module
  • pnpm --dir desktop/frontend build
  • Browser verification: Context overview → dependency file → close preview now hides the preview and restores the file tree.

auto-merge was automatically disabled June 11, 2026 03:28

Pull request was closed

@SivanCola SivanCola deleted the feature/context-overview-status-metrics branch June 11, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants