fix(desktop): keep composer usable beside workspace / 保持工作区旁输入区可用#3886
Merged
esengine merged 2 commits intoJun 11, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
esengine
approved these changes
Jun 11, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Good follow-up to #3878. The comfort-width reservation (560 when the dock is open, 400 otherwise) plus the 280px min-render threshold is a sensible way to keep the composer readable instead of rendering a useless sliver, and the More-menu overflow reuses the existing intent-menu open/close/reduced-motion pattern cleanly. A11y on the listbox is there, both locales are updated, and tightening hasEffort to require levels avoids an empty menu. Layout-only, no data path. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
#3878 fixed right-side workspace clipping, but very wide workspace layouts could still squeeze the chat composer until bottom controls became hard to read. This follow-up keeps the composer usable while still allowing the workspace to shrink, rail, or maximize.
Validation
pnpm --dir desktop/frontend run check:csspnpm --dir desktop/frontend run buildpnpm --dir desktop/frontend run test